Allow non-serial port device addresses #209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the config to dictate what ports are presented as options on the main web interface. The previous approach only listed serial ports that were automatically detected. This commit provides the user with the option of providing custom ports through the config, which is useful when debugging on machines that do not have serial ports available.
olivierdelree
added
enhancement
celefthe
requested changes
May 30, 2024
|
Now that I look at it a bit more, maybe the defaults of |
celefthe
approved these changes
Dec 11, 2024
|
@olivierdelree any ideas why the CI falls over? Getting the following when the tests run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the ability to supply custom addresses for the input and reward devices through the config.
These custom addresses are synced with the web interface so that they are available from the dropdown menu. Additionally, when starting a session, the address values are updated in the config.